Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: individual support for manual checks and exceptions #85

Merged
merged 3 commits into from Jan 4, 2023
Merged

feat: individual support for manual checks and exceptions #85

merged 3 commits into from Jan 4, 2023

Conversation

truptilangalia-crest
Copy link
Contributor

Following changes have been done as part of this PR

  • Instead of maintaining a single file for manual checks and exception, now action will use two individual files, .appinspect.manual.check and .appinspect.expect
  • Added a validation to check all the expected checks which are mentioned in .appinspect.expect must contain a ticket id starting with ADDON/APPCERT
  • Removed condition for checking manual_check is vetted only when included tag is manual, action will check if manual_check is vetted or not for all the tags
  • Upgraded Appinspect version to the latest available 2.30.0
  • Made enhancements to better represent test report in CI stage for easy understanding

@uoboda-splunk
Copy link
Contributor

LGTM

@truptilangalia-crest
Copy link
Contributor Author

with reference to : #84 (comment)
Yes both (with and without .yaml) works. Without .yaml extension we can see the content of the file and determine what kind of data exist. But as suggested have added the extension for better understanding.

@truptilangalia-crest truptilangalia-crest marked this pull request as ready for review January 4, 2023 11:14
@truptilangalia-crest truptilangalia-crest requested a review from a team January 4, 2023 11:15
@truptilangalia-crest truptilangalia-crest merged commit 5165fa6 into main Jan 4, 2023
srv-rr-github-token pushed a commit that referenced this pull request Jan 4, 2023
@semantic-release-bot
chore(release): 1.6.0
0d1f363 
# [1.6.0](v1.5.1...v1.6.0) (2023-01-04)

### Features

* individual support for manual checks and exceptions ([#85](#85)) ([5165fa6](5165fa6))
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@artemrys artemrys deleted the test/appinspect_changes branch February 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nariyanibhargav nariyanibhargav nariyanibhargav approved these changes

@uoboda-splunk uoboda-splunk uoboda-splunk approved these changes

@kkania-splunk kkania-splunk kkania-splunk approved these changes

@rajkarkar-crest rajkarkar-crest Awaiting requested review from rajkarkar-crest

@siddharth-khatsuriya siddharth-khatsuriya Awaiting requested review from siddharth-khatsuriya

@harshilgajera-crest harshilgajera-crest Awaiting requested review from harshilgajera-crest

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@truptilangalia-crest @uoboda-splunk @srv-rr-github-token @nariyanibhargav @kkania-splunk