New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: individual support for manual checks and exceptions #84
Open
truptilangalia-crest
wants to merge
37
commits into
main
Choose a base branch
from
test/appinspect-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 35 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
808f9e8
chore(deps): bump splunk-appinspect from 2.14.1 to 2.30.0
dependabot[bot] ca2f209
test: dockerfile instead of image
truptilangalia-crest 67deec7
test: failed action on not vetting entry
truptilangalia-crest 4afd00e
test: resolved issue with failures
truptilangalia-crest 718b7f5
test: updated conditions for checking vetting file
truptilangalia-crest 49c7d36
test: fixed an error
truptilangalia-crest b2ae886
test: code added for 2 vetting files
truptilangalia-crest 1c00fdb
test: fixed typo in condition
truptilangalia-crest 439e099
test: markdown for expected failures
truptilangalia-crest 376a46c
test: file open with append mode
truptilangalia-crest b2966f4
test: testing
truptilangalia-crest 6d8c397
test: reverted changes
truptilangalia-crest 4bc7bd1
test: removed manual tag condition for generating markdown
truptilangalia-crest 954be01
test: formated result
truptilangalia-crest 672d040
test: formatted results
truptilangalia-crest 2cb9f9f
tets: format changed for failures
truptilangalia-crest b33d646
test: fixed a typo
truptilangalia-crest 1c050e5
test: warjings added
truptilangalia-crest 96f0f59
test: validation added for comment
truptilangalia-crest 0406b25
test: re imported
truptilangalia-crest 2196b6a
test: fixed a tyopo
truptilangalia-crest 39926c2
test: comments added
truptilangalia-crest 50b70ed
test: added checklist
truptilangalia-crest 15724d7
test: added list
truptilangalia-crest 3ab75c8
test: typo fixed
truptilangalia-crest bbc3465
test: updated file names
truptilangalia-crest 2231123
test: added review comment
truptilangalia-crest 2ce3dad
test: format related changes
truptilangalia-crest 44a2d25
test: removed exttra debug statements
truptilangalia-crest 8de57d2
test: replaced set-output
truptilangalia-crest 81a9995
test: code cleanup
truptilangalia-crest ce04283
test: file name changed
truptilangalia-crest bc68710
test: variable name changes
truptilangalia-crest d2679e8
test: readme changed
truptilangalia-crest b07851f
test: resolved review comments
truptilangalia-crest 5f51660
test: pre-commit fixes and added yaml extension
truptilangalia-crest be7541a
test: conflict from main
truptilangalia-crest File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,23 +42,25 @@ python3 /reporter.py $INPUT_RESULT_FILE | |
exit_code=$? | ||
echo "::endgroup::" | ||
|
||
exit_code_failure_check=$exit_code | ||
if [ $exit_code != 0 ]; then | ||
echo "::group::failure_checks" | ||
python3 /compare_checks.py $INPUT_APP_VETTING $INPUT_RESULT_FILE "failure" | ||
exit_code=$? | ||
python3 /compare_checks.py $INPUT_APPINSPECT_EXPECTED_FAILURES $INPUT_RESULT_FILE "failure" | ||
exit_code_failure_check=$? | ||
echo "::endgroup::" | ||
fi | ||
|
||
if [[ "$INPUT_INCLUDED_TAGS" == *"manual"* ]] && [ $exit_code == 0 ]; then | ||
echo "::group::manual_checks" | ||
python3 /compare_checks.py $INPUT_APP_VETTING $INPUT_RESULT_FILE "manual_check" | ||
exit_code=$? | ||
if [ $exit_code == 0 ]; then | ||
echo "successful comparison, generating markdown" | ||
echo "/export_to_markdown.py $INPUT_APP_VETTING $INPUT_MANUAL_CHECK_MARKDOWN" | ||
python3 /export_to_markdown.py $INPUT_APP_VETTING $INPUT_MANUAL_CHECK_MARKDOWN | ||
fi | ||
echo "::group::manual_checks" | ||
python3 /compare_checks.py $INPUT_APPINSPECT_MANUAL_CHECKS $INPUT_RESULT_FILE "manual_check" | ||
exit_code_manual_check=$? | ||
echo "::endgroup::" | ||
|
||
if [ $exit_code_failure_check == 0 ] && [ $exit_code_manual_check == 0 ] ; then | ||
echo "::group::generate_markdown" | ||
echo "successful comparison, generating markdown" | ||
python3 /export_to_markdown.py $INPUT_APPINSPECT_MANUAL_CHECKS $INPUT_MANUAL_CHECK_MARKDOWN | ||
python3 /export_to_markdown.py $INPUT_APPINSPECT_EXPECTED_FAILURES $INPUT_EXPECTED_FAILURE_MARKDOWN | ||
echo "::endgroup::" | ||
fi | ||
|
||
exit "$exit_code" | ||
exit "$(($exit_code_failure_check || $exit_code_manual_check))" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newline needed - please fix |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about keeping
.yaml
extension in the file name? it's more clear what kind of data is inside