fix: Deprecate preserve infra functionality. #262
Conversation
Customer-facing release notes: * feat: remove Firefox from ui tests (#228) * fix: remove artifact-registry (#226) * feat(release): addonfactory-packaging-toolkit-action removal (#230) * fix: move poetry lock --check to unit tests job (#245) * feat: remove ESCU tests from reusable workflow (#234) * Splunk AppInspect CLI Action update to v2.6 * fix: combining splunk versions for python3.9 matrix issues (#257) Test runs: * splunk/splunk-add-on-for-microsoft-sysmon#315 * splunk/splunk-add-on-for-google-workspace#545
pbajaj-crest
changed the title
pbajaj-crest
assigned mbruzda-splunk, kdoroszko-splunk, marc-jasinski and mkolasinski-splunk and unassigned marc-jasinski
| - name: run-tests | ||
| id: run-tests | ||
| timeout-minutes: 340 | ||
| continue-on-error: true | ||
| env: | ||
| ARGO_TOKEN: ${{ steps.get-argo-token.outputs.argo-token }} | ||
| uses: splunk/wfe-test-runner-action@v1.6 | ||
| uses: splunk/wfe-test-runner-action@fix/ADDON-69999-deprecate-preserve-infra |
There was a problem hiding this comment.
Let's remember to change that after merging respective PR on wfe-test-runner-action.
There was a problem hiding this comment.
Let's remember to change that after merging respective PR on
wfe-test-runner-action.
@kdoroszko-splunk sure this will be update once the wfe-test-runner new changes will be merged
| @@ -385,11 +299,9 @@ jobs: | |||
| semgrep: | |||
| runs-on: ubuntu-latest | |||
| name: security-sast-semgrep | |||
| needs: | |||
| - setup-workflow | |||
| if: github.actor != 'dependabot[bot]' | |||
There was a problem hiding this comment.
Why this condition?
There was a problem hiding this comment.
Why this condition?
@kdoroszko-splunk it is to ensures that the job named security-sast-semgrep is only executed when the actor triggering the workflow is not the Dependabot GitHub bot. if that will create an shall i remove that?
|
I'm thinking maybe we should treat this as a feat release, not fix? |
|
@pbajaj-crest can you also provide a test run where we use new preserve infra functionality? |
@mbruzda-splunk sure i will update you with new addon worflow |
pbajaj-crest
force-pushed
the
fix/ADDON-69999-deprecate-preserve-infra
branch
from
0d0e268
to
46d0b10
Compare
@mbruzda-splunk please check the test run for MSCS |
Description