Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split marker to ui_marker and mod_input_marker for test cases #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kgwizdz-splunk
Copy link

@kgwizdz-splunk kgwizdz-splunk commented Apr 25, 2024

UI tests may be slow to execute so we need to explore adding the ability to use markers that can speed up test execution by parallelizing UI tests. This is currently implemented only for modinput tests (configuration example can be found here).

Example workflow execution: https://github.com/splunk/splunk-add-on-for-amazon-web-services/pull/1220

@kgwizdz-splunk kgwizdz-splunk requested a review from a team as a code owner April 25, 2024 15:10
@mkolasinski-splunk
Copy link
Contributor

@kgwizdz-splunk Could you please provide here a link to an example workflow execution with those changes?

@kgwizdz-splunk
Copy link
Author

@mkolasinski-splunk Sure, added to description

@artemrys
Copy link
Member

Just to make sure we are on the same page - if you want this change to be released - let's have this PR be against main branch and use fix instead of feat. So it can be seamlessly integrated into all the TAs.

@artemrys artemrys changed the base branch from develop to main May 6, 2024 12:07
@artemrys artemrys changed the title feat: split marker to ui_marker and mod_input_marker for test cases fix: split marker to ui_marker and mod_input_marker for test cases May 7, 2024
@artemrys
Copy link
Member

artemrys commented May 7, 2024

@kgwizdz-splunk please resolve conflicts.

Let's avoid making this breaking change - let's not rename the existing marker.

@artemrys
Copy link
Member

artemrys commented May 8, 2024

@kgwizdz-splunk please check out pre-commit failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants