Fix: skip fossa if there are no main deps for poetry #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
reviewed
Jan 11, 2024
| @@ -290,8 +290,7 @@ jobs: | |||
| - uses: actions/setup-python@v5 | |||
| - name: remove dev dependencies | |||
| run: | | |||
| sudo apt install crudini | |||
| pip install poetry==1.5.1 | |||
| pip3 install crudini poetry==1.5.1 | |||
There was a problem hiding this comment.
Let's have a PR with the logic - let's not run fossa if there is no main dependencies.
I'll talk to Andrzej and we will get an approval for that from legal.
There was a problem hiding this comment.
@artemrys I reworked the PR. I didn't handle THIRDPARTY file as we are waiting for the decision from legal team
mbruzda-splunk
changed the title
|
We are waiting for the meeting with Legal to discuss what we should do in this case. Do not merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洃 THIS PR IS CURRENTLY BLOCKED. DO NOT MERGE. DO NOT DELETE 馃洃
Temporary workaround for: https://splunk.atlassian.net/browse/ADDON-67632
Tested here: https://github.com/splunk/splunk-add-on-for-checkpoint-log-exporter/actions/runs/7530407832/job/20496718345