Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/built in linter #1039

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from
Draft

Feat/built in linter #1039

wants to merge 14 commits into from

Conversation

MateuszMa
Copy link
Contributor

As described in #1037

Pylint library selected as optional
Shows errors and warnings

@MateuszMa MateuszMa linked an issue Feb 1, 2024 that may be closed by this pull request
Feature request: Run a linter during build command to spot and report possible parsing errors or warnings. #1037
Closed
@MateuszMa MateuszMa marked this pull request as ready for review February 6, 2024 16:55
@MateuszMa MateuszMa requested review from a team as code owners February 6, 2024 16:55
@MateuszMa
Copy link
Contributor Author

UPDATE:

  • pylint is not provided and not mentioned in poetry as it is not treated as optional. User should install pylint on their own pick the version that best suites their environment.
  • pylint log warnings and errors only - ignores all PEP suggestions, refactor suggestions and import errors (ie. missing splunk platform libs)
  • smoke test mocks pylinter thus the library is not required for testing

@vtsvetkov-splunk
Copy link
Collaborator

should the title be chore: add build-in linter?

@artemrys artemrys marked this pull request as draft April 16, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Run a linter during build command to spot and report possible parsing errors or warnings.
2 participants
@MateuszMa @vtsvetkov-splunk