Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDKS-2199] Add Cors. Fix listener destroy. Update changes file #109

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

[SDKS-2199] Add Cors. Fix listener destroy. Update changes file #109

wants to merge 2 commits into from

Conversation

emmaz90
Copy link
Contributor

@emmaz90 emmaz90 commented Oct 24, 2022

Split Evaluator

What did you accomplish?

Added Cors
Fix listener destroy
Update changes file

How do we test the changes introduced in this PR?

Extra Notes

NicoZelaya
NicoZelaya reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@NicoZelaya NicoZelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to be merged to development afterwards, but let's iterate on the options and how to prevent this from being too lose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoZelaya NicoZelaya NicoZelaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmaz90 @NicoZelaya