Merge semver to dev #504
Merged
Merge semver to dev #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added semver class
Semver equalto matcher
Semver greater equalto matcher
Semver inlist matcher
Semver between matcher
added spec to splitchanges and auth urls, and updated tests
added less than or equal semver matcher
|
SonarQube Quality Gate
|
sanzmauro
reviewed
May 8, 2024
client/src/main/java/io/split/engine/matchers/BetweenSemverMatcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/engine/matchers/EqualToSemverMatcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/engine/matchers/GreaterThanOrEqualToSemverMatcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/engine/matchers/InListSemverMatcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/engine/matchers/InListSemverMatcher.java
Outdated
Show resolved
Hide resolved
client/src/main/java/io/split/engine/matchers/LessThanOrEqualToSemverMatcher.java
Outdated
Show resolved
Hide resolved
RawAuthResponse constructor first checks to ensure provided token is not null and is not empty. Existing implementation used != operator to detect non-empty string, thus failed to handle when provided token is actually empty, i.e. "". The token comparison logic in RawAuthResponse constructor is now updated to use isEmpty() instead, more specifically, (token != null && !token.isEmpty()) to properly handle "" case. New test case with sample json has been added for validation; the test prior to the change would fail with java.lang.ArrayIndexOutOfBoundsException.
…h_empty_token Fix empty token handling in RawAuthResponse constructor
mmelograno
approved these changes
May 15, 2024
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.