Cucumber #248
Cucumber #248
Conversation
* Add CucumberSplit * Add URL in JavaDoc * Improve the Cucumber example to be more realistic * disambiguation
|
@aslakhellesoy could you pease give it a try before a deploy to maven this artifact? |
|
Thanks @patricioe - I'll take it for a spin.... |
| <dependency> | ||
| <groupId>io.cucumber</groupId> | ||
| <artifactId>cucumber-java</artifactId> | ||
| <version>6.10.4</version> |
There was a problem hiding this comment.
I would add <scope>provided</scope> here so that users can choose a more recent version of Cucumber when it's released. (The API we're using is stable and unlikely to change).
| <dependency> | ||
| <groupId>io.cucumber</groupId> | ||
| <artifactId>cucumber-junit</artifactId> | ||
| <version>6.10.4</version> |
There was a problem hiding this comment.
I would add <scope>test</scope> here since it's not used in src/main, only in src/test.
There was a problem hiding this comment.
I've suggested two changes to pom.xml.
I also suggest adding this to the root pom.xml so the module gets included in the root level build:
<modules>
<module>testing</module>
<!-- Add this line -->
<module>testing-cucumber</module>
<module>client</module>
</modules>Thanks a lot!!
|
@aslakhellesoy done |
|
SonarQube Quality Gate
|
|
@aslakhellesoy deployed. java-client-testing-cucumber-1.0.0-rc1.jar I won't merge the PR yet. |
|
I've now moved this code to https://github.com/cucumber/split-java/ and added some documentation. Please remove the code I have contributed now that Cucumber-Split has a new home. |
This is a refactor from pull request #247 which incorporates the changes into a separate maven module for ease of integration.