Semver class implementation #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
approved these changes
May 13, 2024
javrudsky
requested changes
May 13, 2024
javrudsky
requested changes
May 14, 2024
| private var major: Int64 | ||
| private var minor: Int64 | ||
| private var patch: Int64 | ||
| private var major: Int64 = -1 |
There was a problem hiding this comment.
How about replacing this values by a struct like:
struct SemverModel {
let major: Int64
let minor: Int64
let patch: Int64
...
}
|
|
||
| return (major, minor, patch) | ||
| } | ||
|
|
||
| private func setVersion() -> String { |
There was a problem hiding this comment.
This could be a function toString() from SemverModel
Split/Matchers/Semver/Semver.swift
Outdated
| return metadataString | ||
| } | ||
|
|
||
| private func getAndRemovePreReleaseIfExists(_ vWithoutMetadata: String) throws -> (preRelease: [String], isStable: Bool, versionWithoutPreRelease: String) { |
There was a problem hiding this comment.
Maybe you can use the model here too:
func versionWithoutPreRelease(withoutMetaData: String) throws -> SemverModel {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?