ldap implementation

[vincentDcmps]

Hi like request in #181 I will try to work on LDAP integration I create this pull request for following

[codecov]

Codecov Report

Merging #237 (187c513) into master (cf73d5a) will increase coverage by 0.02%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   86.39%   86.42%   +0.02%     
==========================================
  Files          46       47       +1     
  Lines        3779     3845      +66     
==========================================
+ Hits         3265     3323      +58     
- Misses        514      522       +8     

Impacted Files	Coverage Δ
supysonic/managers/ldap.py	86.66% <86.66%> (ø)
supysonic/managers/user.py	97.40% <92.00%> (-2.60%)	⬇️
supysonic/config.py	95.83% <100.00%> (+0.08%)	⬆️
supysonic/db.py	92.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[vincentDcmps]

I take inspiration from #250 to implement LDAP
still need:

• test
• documentation

[vincentDcmps]

Hi I have some issue for write test do you have any idea on how to do a ldap mock?

[spl0k]

I wish there was some kind of embeddable directory for LDAP, kinda like SQLite...

Maybe you can use the unittest.mock library to patch the ldap3 library and use the side effects to return the data you need?

[vincentDcmps]

hello, I have added some test thanks for your advice!!
@spl0k Could you review code and tell me if somebody is not correct.

PS: fail test seem not link with my modification

[spl0k]

Hello.

Sorry I hadn't taken the time to respond yet. This is something I'd like to try with a real LDAP backend but I lack knowledge in the matter. I'll get back to you as soon as I manage to set up a LDAP server.

[vincentDcmps]

Hi if you want try with fast LDAP instalation you could take a look on LLDAP side

[spl0k]

Hello. I actually managed to setup a basic OpenLDAP server some time ago.

I remember noticing uncaught errors if the server wasn't setup properly but I don't recall if it was with your PR or #250.
Then I wasn't satisfied with how the current auth and LDAP are somehow tangled together so I started working some kind of pluggable auth system... and kinda gave up along the way.