Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Exception in fresh development environment (LocalGit) #1069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gustavotemple
Copy link

@gustavotemple gustavotemple commented Jun 19, 2023

After following the guide below in a fresh development environment (LocalGit):
https://spinnaker.io/docs/community/contributing/code/developer-guides/dev-env/getting-set-up/

I got:

IllegalArgumentException: Could not resolve placeholder 'services.clouddriver.base-url' in value "${services.clouddriver.base-url}"
IllegalArgumentException: Could not resolve placeholder 'services.front50.base-url' in value "${services.front50.base-url}"
IllegalArgumentException: Could not resolve placeholder 'services.igor.base-url' in value "${services.igor.base-url}"

When I run ./gradlew run

baseUrl: http://localhost:7003
front50:
baseUrl: http://localhost:8080
igor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest defaulting igor to enabled: false as it isn't a core service.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's NORMALLY a default spinnaker.yml file that should set all of these appropriately. I know that's deployed via halyard/operator. I though local dev had it someplace too, or at least, had localhost as the defaults on some of these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Kork?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these files were included someplace else and so MAY not need to be set this way kinda thing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the gate, only the fiat baseUrl was missing:
https://github.com/spinnaker/gate/pull/1671/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants