Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated positional arguments for translation merges #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fossfreedom
Copy link
Contributor

Meson has now removed the positional arguments for
the translation merges. This causes a FTBFS scenario.

Meson has now removed the positional arguments for
the translation merges.  This causes a FTBFS scenario.
@travrei
Copy link

travrei commented May 12, 2022

Nice! Now i can use it!

@eli-schwartz
Copy link

Meson has now removed the positional arguments for the translation merges. This causes a FTBFS scenario.

This description gives an inaccurate impression that Meson dropped support for something which it formerly supported.

This is incorrect. Meson never supported a positional argument here at all, and never did anything with it if you added one anyway. During routine refactoring, type validation was added to this function to make sure that any kwargs use the values that are documented to work -- in the process, it also validated that, per the documentation, no positional arguments are used.

Naturally, this broke any meson.build which contained an invalid positional argument, which turned out to be... lots of projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants