Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported source version #327

Closed
wants to merge 4 commits into from

Conversation

nitroin
Copy link
Contributor

@nitroin nitroin commented May 23, 2023

@SupportedSourceVersion is used to indicate the latest source version an annotation processor supports.

Link to javadoc.

I think is safe to say that we can work with the latest lts.

This should also silent this warning when working with the latest lts:

[WARNING] Supported source version 'RELEASE_8' from annotation processor 'com.speedment.jpastreamer.fieldgenerator.StandardFieldGeneratorProcessor' less than -source '17'

@julgus
Copy link
Member

julgus commented May 23, 2023

Sounds reasonable! However we need to investigate why the build fails with these changes:

image

@nitroin
Copy link
Contributor Author

nitroin commented May 23, 2023

Yup, I will mark as draft for now.

@nitroin nitroin marked this pull request as draft May 23, 2023 11:17
@nitroin
Copy link
Contributor Author

nitroin commented May 24, 2023

I finally decided to drop the annotation.

I think that it was originally added to indicate the minimum supported version, but accordingly to the spec it signals the latest instead. I think that it safe to say that we do support Java greater than version 8.

On the other hand we cannot reference RELEASE_17 if we source/target/release for Java 8. So I suggest to drop the annotation entirely so that jpastreamer does not confuse users with the above warning when using versions greater than 8.

Any other change looks like out-of-scope since I think is undesirable to officially drop Java 8.

@nitroin nitroin marked this pull request as ready for review May 24, 2023 09:21
@julgus
Copy link
Member

julgus commented May 26, 2023

Hmm... this is really interesting. When I tried dropping the annotation it instead seems as if it falls back on a default value - which is Java 6! I guess we need to stick with RELEASE_8 for now. We have actually considered dropping support for Java 8 in the near future and moving to Java 11, but it sounds like you disagree with that. Would you mind sharing why?

image

@julgus julgus closed this May 30, 2023
@julgus julgus mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants