Add series data entry feature #4804
Conversation
Triggered by 0680b87 on branch refs/heads/issue-545
CarolineDenis
force-pushed
the
issue-545
branch
from
ffa931c
to
5cf1c90
Compare
| {resource.specifyTable.name === 'CollectionObject' && | ||
| !isInRecordSet && | ||
| showBulkCarryInput ? ( | ||
| <Label.Inline> |
There was a problem hiding this comment.
should this be in a dialog?
otherwise, you would need to add aria-controls and forward focus from the button to input on button click
| if (originalResourceId !== undefined) { | ||
| ids.push(originalResourceId); | ||
| } | ||
| if (Array.isArray(result)) { |
There was a problem hiding this comment.
change the signature of handleAdd() to make it be callable with an array of resources rather than one resource
and use that to simplify the code here
that would also shift the responsibility to the consumer of Save for deciding how it wants to handle or not to handle the case of more than one resource being present (i.e imagine that some code right now does a redirect on handleAdd() - by calling handleAdd multiples times here, that code is now potentially broken; where as by changing handleAdd signature to include array, that place would now be forced to consider how the array case needs to be handled)
There was a problem hiding this comment.
and once handleAdd() is being called with an array, there won't be need for handleCarryBulk() anymore as it can be combined
| const startingResource = fetchResource('CollectionObject', ids[0]); | ||
| const endingResource = fetchResource('CollectionObject', ids.at(-1)!); | ||
| const startingResourceCatNumber = (await startingResource).catalogNumber; | ||
| const endingResourceCatNumber = (await endingResource).catalogNumber; |
There was a problem hiding this comment.
once you change the code to remove handleCarryBulk and make handleAdd receive an array of resources, you won't need to do re-fetching of resources manually here as handleAdd is already being called with fetched resource
Fixes #545
Checklist
and self-explanatory (or properly documented)
Testing instructions