refactor(FormEditor): use .getRelationship() in viewSpec #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifyweb/frontend/js_src/lib/components/FormEditor/viewSpec.ts
Outdated
Show resolved
Hide resolved
maxpatiiuk
commented
Apr 13, 2024
| const cellRelatedTableName = cellRelationship?.relatedTable.name; | ||
| const cellRelationship = | ||
| typeof cellName === 'string' | ||
| ? syncers.field(table?.name).serializer(cellName)?.at(-1) |
There was a problem hiding this comment.
by using syncers.field, an error will be thrown on invalid field name
maxpatiiuk
commented
Apr 13, 2024
| @@ -658,7 +659,7 @@ export const syncers = { | |||
| ]) as TYPE_MAPPER[keyof TYPE_MAPPER]) ?? ('Unknown' as const); | |||
| const spec = mapper[type] ?? mapper.Unknown; | |||
| const { serializer } = syncers.object( | |||
| spec(cell, { ...extraPayload, rawType }) | |||
| spec(cell, extraPayload, rawType) | |||
There was a problem hiding this comment.
this was causing extraPayload object to loose it's prototype chain, thus table was loosing the getRelationship and all other methods
CarolineDenis
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code in response to code changes in PR #4748 (it was merged before I had a chance to fix it)
Checklist
and self-explanatory (or properly documented)
Testing instructions