New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset auto width for forms when not in subForm to avoid shifts #4743
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taxon fields are affected in all areas of the software:
This fix works in data entry:
Screen.Recording.2024-04-05.at.11.05.20.AM.mov
But the issue is not fixed in trees dialog:
Screen.Recording.2024-04-05.at.11.07.03.AM.mov
Or embedded dialogs from qcbx (CO in data entry and record set)
Screen.Recording.2024-04-05.at.11.17.50.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
-
Go to data entry
-
Click on taxon
-
Input a parent of taxon
-
Delete what you selected and reenter a new taxon
-
See there is no form shift
-
test other places with forms, other data entry forms, app resources, record sets, interactions. Verify width is ok
In app resources if you try to type in the taxon field there is a form shift
LJ2yj8YSHe.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than changing this setting, I would propose the following fix:
if treeitem.parent changes, and current treeitem.rank is not a valid rank given the set of ranks allowed for a child of a given treeitem.parent, then unset the treeitem.rank
(i.e when you fetched new ranks in response to 'parent' changing, if current rank is not in the list of possibilities, unset it)
this would fix the API url becoming visible to the user
Fixes #4738
Checklist
and self-explanatory (or properly documented)
Testing instructions
Go to data entry
Click on taxon
Input a parent of taxon
Delete what you selected and reenter a new taxon
See there is no form shift
test other places with forms, other data entry forms, app resources, record sets, interactions. Verify width is ok