Account for localization.isrequired with field.isRequired

[melton-jason]

Fixes #4720

Currently the field.localization.isrequired is not present in field.isRequired. The fieldDefinition only contains information from the specify_datamodel.xml (https://files.specifysoftware.org/schema/version/2.10/), and does not contain any information on the splocalecontaineritem which represents the disclipline's configuration for the field.

Consider the two CollectionObject fields uniqueIdentifier and totalValue. In the currently logged in discipline, totalValue is marked as required and uniqueIdentifier is not required.

The following code is added to the constructor of FieldBase

if (
      table.name === 'CollectionObject' &&
      ['totalvalue', 'uniqueidentifier'].includes(
        fieldDefinition.name.toLowerCase()
      )
    )
      console.log(
        table.name,
        fieldDefinition.name,
        table.localization.items[fieldDefinition.name.toLowerCase()]
          ?.isrequired,
        fieldDefinition.required,
        this.isRequired
      );

which outputs:

I agree it would make sense to include the `field.localization.isrequired` with the `field.isRequired`.

#4703 (comment)

Checklist

• Self-review the PR after opening it to make sure the changes look good
  and self-explanatory (or properly documented)
• Add automated tests
• Add relevant issue to release milestone

Testing instructions

[maxpatiiuk]

need a test as this is a critical file
otherwise, all good

[maxpatiiuk]

could you please add the test case that ensures schema config setting impacts the isRequired prop?

specify7/specifyweb/frontend/js_src/lib/components/DataModel/__tests__/specifyField.test.ts

Lines 48 to 61 in 0257f82

	describe('isRequired', () => {
	test('not-required field', () =>
	expect(tables.CollectionObject.getField('catalogNumber')?.isRequired).toBe(
	false
	));
	test('field required by schema', () =>
	expect(tables.Accession.getField('accessionNumber')?.isRequired).toBe(
	true
	));
	test('field required by front-end override', () =>
	expect(tables.Taxon.getField('parent')?.isRequired).toBe(true));
	test('field made optional by front-end override', () =>
	expect(tables.Attachment.getField('tableID')?.isRequired).toBe(false));
	});