New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify header separator in query to avoid issue during export #4678
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really a microsoft's fault as they still don't use utf8 as the default
it's 2024 and utf8 should be used universally by now - https://utf8everywhere.org/
alas, we can't do much about this.
and i guess this customization would be useful for other use cases too - code looks good here, but see two comments
specifyweb/frontend/js_src/lib/components/Preferences/UserDefinitions.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/WbPlanView/mappingPreview.ts
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/WbPlanView/mappingPreview.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We need to also instruct the testers to open the exported CSV files in Excel to ensure that the encoding is interpreted correctly |
Triggered by 6383151 on branch refs/heads/issue-4491
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- run a query with Taxon Full Name by example
- verify that there is a dash and not a dot between Taxon and Full Name
- exported CSV files in Excel to ensure that the encoding is interpreted correctly
Looks good, tried with various different fields and all seemed to show the dash and CSV files show up correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #4491
Checklist
and self-explanatory (or properly documented)
Testing instructions