Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify header separator in query to avoid issue during export #4678

Open
wants to merge 8 commits into
base: production
Choose a base branch
from

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Mar 22, 2024

Fixes #4491

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • run a query with Taxon Full Name by example
  • verify that there is a dash and not a dot between Taxon and Full Name
  • exported CSV files in Excel to ensure that the encoding is interpreted correctly

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really a microsoft's fault as they still don't use utf8 as the default
it's 2024 and utf8 should be used universally by now - https://utf8everywhere.org/
alas, we can't do much about this.
and i guess this customization would be useful for other use cases too - code looks good here, but see two comments

@CarolineDenis CarolineDenis requested a review from a team March 25, 2024 13:33
@CarolineDenis CarolineDenis marked this pull request as ready for review March 25, 2024 13:33
@CarolineDenis CarolineDenis marked this pull request as draft March 25, 2024 14:11
@CarolineDenis CarolineDenis marked this pull request as ready for review March 25, 2024 14:31
@CarolineDenis CarolineDenis changed the title Add pref to use dot to join headers or not in query results Modify header separator in query to avoid issue during export Mar 26, 2024
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CarolineDenis CarolineDenis added this to the 7.9.6 milestone Mar 27, 2024
@grantfitzsimmons
Copy link
Contributor

Testing instructions

  • run a query with Taxon Full Name by example
  • verify that there is a dash and not a dot between Taxon and Full Name

We need to also instruct the testers to open the exported CSV files in Excel to ensure that the encoding is interpreted correctly

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • run a query with Taxon Full Name by example
  • verify that there is a dash and not a dot between Taxon and Full Name
  • exported CSV files in Excel to ensure that the encoding is interpreted correctly

Looks good, tried with various different fields and all seemed to show the dash and CSV files show up correctly.
Screenshot 2024-05-07 154123

@emenslin emenslin requested a review from a team May 7, 2024 20:59
Copy link

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • verify that there is a dash and not a dot between Taxon and Full Name
  • exported CSV files in Excel to ensure that the encoding is interpreted correctly

Dashes are now present 👍👍

EXCEL_0b8c2SywPc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Dev Attention Needed
Development

Successfully merging this pull request may close these issues.

Add an option to remove special characters from column headings during exports
5 participants