Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow independent subviews #3125

Draft
wants to merge 20 commits into
base: production
Choose a base branch
from
Draft

Allow independent subviews #3125

wants to merge 20 commits into from

Conversation

maxpatiiuk
Copy link
Member

@maxpatiiuk maxpatiiuk commented Mar 8, 2023

Fixes #114
Fixes #3127

but only if sub view is displayed as a button (because button opens a dialog, and dialog has a save button, and dialog creates a separate <form> - thus validation errors in independent sub-view are scoped to that sub-view)

This is just a one-line change because 50% of the work was done in 7.7
Now, the other 50% is testing - please test the hell out of this

Suggestions for testing:

  • Collection Object -> Accession as a subview button
  • Collecting Event -> Collection as a subview
    • try opening Collection Object -> Collecting Event -> Collection Object that way
  • Save main form before saving sub view
    • Especially when sub view has validation errors
  • Also do testing in record sets (especially with saving and validation errors and going between record set records)
  • Test Interpret all independent subviews as buttons #3127

Copy link
Contributor

@chanulee1 chanulee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot associate CO with an Accession through the Accession form. After adding a CO and reloading, see that the CO has not been added. Querying shows that the relationship has not been established. Also, adding the CO does not trigger the save button.

QprdcqZl0S.mp4

https://coldfish-issue-114.test.specifysystems.org/specify/view/accession/827/

@grantfitzsimmons
Copy link
Member

Cannot associate CO with an Accession through the Accession form. After adding a CO and reloading, see that the CO has not been added. Querying shows that the relationship has not been established. Also, adding the CO does not trigger the save button.

I was able to recreate this issue without using an auto-generated form as well.

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as @chanulee1, I cannot add items to an independent subview and have them remain.

@maxpatiiuk maxpatiiuk linked an issue Mar 18, 2023 that may be closed by this pull request
@maxpatiiuk
Copy link
Member Author

Also, need to add ability to add existing independent subviews using search, rather than create new (like in sp6)

@grantfitzsimmons
Copy link
Member

We should continue developing this idea further I think.

@grantfitzsimmons grantfitzsimmons modified the milestones: 7.9.2, 7.9.4 Nov 2, 2023
@CarolineDenis CarolineDenis modified the milestones: 7.9.5, 7.9.6 Mar 13, 2024
@melton-jason melton-jason marked this pull request as draft May 23, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
5 participants