-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow independent subviews #3125
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot associate CO with an Accession through the Accession form. After adding a CO and reloading, see that the CO has not been added. Querying shows that the relationship has not been established. Also, adding the CO does not trigger the save button.
QprdcqZl0S.mp4
https://coldfish-issue-114.test.specifysystems.org/specify/view/accession/827/
I was able to recreate this issue without using an auto-generated form as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as @chanulee1, I cannot add items to an independent subview and have them remain.
Also, need to add ability to add existing independent subviews using search, rather than create new (like in sp6) |
We should continue developing this idea further I think. |
Fixes #114
Fixes #3127
but only if sub view is displayed as a button (because button opens a dialog, and dialog has a save button, and dialog creates a separate
<form>
- thus validation errors in independent sub-view are scoped to that sub-view)This is just a one-line change because 50% of the work was done in 7.7
Now, the other 50% is testing - please test the hell out of this
Suggestions for testing: