Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schemaconfig isRequired not being respected to field.isRequired #4720

Open
melton-jason opened this issue Apr 2, 2024 · 0 comments · May be fixed by #4721
Open

Schemaconfig isRequired not being respected to field.isRequired #4720

melton-jason opened this issue Apr 2, 2024 · 0 comments · May be fixed by #4721
Assignees
@melton-jason
Labels
1 - Bug Incorrect behavior of the product

Comments

@melton-jason
Copy link
Contributor

melton-jason commented Apr 2, 2024 •
edited

Describe the bug
Currently on the frontend representation of the datamodel, a specific field's isRequired attribute is not accounting for whether it is marked as required or not via it's associated SplocaleContainerItem (i.e., in SchemaConfig).

Only the Specify 7 field overwrites and the base field definition in the specify_datamodel.xml is being considered:

specify7/specifyweb/frontend/js_src/lib/components/DataModel/specifyField.ts

Lines 134 to 139 in 968fc20

this.isRequired =
globalFieldOverride === 'required'
? true
: globalFieldOverride === 'optional'
? false
: fieldDefinition.required;

See #4703 (comment)
@melton-jason melton-jason added the 1 - Bug Incorrect behavior of the product label Apr 2, 2024
@melton-jason melton-jason self-assigned this Apr 2, 2024
melton-jason added a commit that referenced this issue Apr 2, 2024
@melton-jason
Account for localization.isrequired with field.isRequired
1fd8bdc 
Fixes #4720
@melton-jason melton-jason linked a pull request Apr 2, 2024 that will close this issue
Draft
3 tasks
@melton-jason melton-jason changed the title Schmaconfig isRequired not being respected to field.isRequired Schemaconfig isRequired not being respected to field.isRequired Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melton-jason melton-jason

Labels
1 - Bug Incorrect behavior of the product
Projects
Front-End Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for localization.isrequired with field.isRequired specify/specify7
1 participant
@melton-jason