Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPGA tutorial #1438

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

FPGA tutorial #1438

wants to merge 12 commits into from

Conversation

TizianoDeMatteis
Copy link
Contributor

Basic FPGA tutorial.

The run jupyter notebook can be accessed here: https://nbviewer.org/github/spcl/dace/blob/fpga_tutorial/tutorials/fpga.ipynb

**Note: ** currently there are glitches in the rendered notebook

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No inline comments:

  • date -> dace
  • explict -> explicit
  • commented code blocks can just be code blocks with a comment in them
  • optmize -> optimize
  • "library nodes Library nodes" -> "library nodes. Library nodes are high-level nodes that can represent a wide variety of operators. In this case, the two matrix multiplications"...
  • "expension this FPGA" -> "expansion. This FPGA"
  • "expensions" -> "expansions" (apply everywhere)
  • "need of off-chip" -> "need for off-chip"
  • "multiple memory buffer being" -> "multiple memory buffers being"
  • "we can distributed" -> "we can distribute"
  • ", that" -> ", which"
  • "of its program" -> "of their program"
  • "applying DaCe auto-optimization heuristic" -> either "heuristics" or "the DaCe". The former is likely better
  • "a set of simplification to" -> "a set of simplification passes to"
  • "of the [...] ones" -> "of [...]."
  • "can not currently being tuned by the user." - what does this mean?
  • "Let's start again from the SDFG parsing" -> "Let's start again from parsing the SDFG"
  • "explicitely" -> "explicitly"
  • "execute FPGA program" -> "execute FPGA programs"
  • "properly" -> ""
  • "For example, to enable Hardware execution via command line (other" -> "Hardware execution can be enabled via the command line, or other"
  • "as follow" -> "as follows"
  • ", that" -> ", which"
  • "bistream" -> "bitstream"
  • "executed the program" -> "execute the program"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these should be fixed now.

@tbennun tbennun mentioned this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants