[fix practice_add_new_report] Add a condition to check if the practice supervisor is selected. #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a new report is added while the practice supervisor is not selected, the application crashes with 500: Internal Server Error.
This PR fixes this error and suggests the user to select the supervisor via a flash error message.
Steps to reproduce the bug
Context
This line tries to find a supervisor but fails because
current_thesis.supervisor_id
isNone
spbu_se_site/src/flask_se_practice.py
Line 429 in 2cd65d2
Suggested solution
A condition is added to check if the supervisor is selected. In case if the supervisor is not selected flash an error message which suggests to select the supervisor.
Alternative solution
Prohibit to create a new practice unless a supervisor is selected.