firstly read temperature for avoiding wrong calculation #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng readFloatAltitudeMeters() for correct result
|
Thanks for the PR! Does this method come from the datasheet? Why do you readFloatPressure twice? Hmm, it looks like t_fine gets set in readTempC and is used in readFloatPressure. |
|
It has fixed the wrong calculation. You can try it with or without my two-line containing commit. (it will probably give the wrong meter calculation without this commit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used the library and it was giving wrong altitude values because of not calling the readTempC() before calling readFloatAltitudeMeters(). Then I have called it and it has been fixed.