bugfix: set the matrix public_baseurl #2366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of computing this from the `matrix_server_fqn_matrix` this should use the pre-computed (or overridden!) `matrix_homeserver_url` so that it is possible to set the homeserver port, if that isn't `443`
|
The comments there seem to indicate that a trailing slash is necessary, but maybe that's not really required? |
|
Imo this excerpt from the well-known spec applies here as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of computing this from the
matrix_server_fqn_matrixthisshould use the pre-computed (or overridden!)
matrix_homeserver_urlsothat it is possible to set the homeserver port, if that isn't
443