Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible.posix collection as a requirement, latest release. #2241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oscarcarlsson
Copy link

Otherwise roles/custom/matrix-synapse/tasks/import_media_store.yml won't run, taking the entire playbook with it.

Otherwise roles/custom/matrix-synapse/tasks/import_media_store.yml
won't run, taking the entire playbook with it.
@spantaleev
Copy link
Owner

I wonder if we should be installing these collections ourselves or let the user's Ansible distribution do it. On Archlinux, the ansible package installs some 50+ collections already, so nothing else is necessary. On Alpinelinux (which handles our devture/ansible container, see docs/ansible.md for running Ansible in a container), it's the same - all these collections are included as part of the Ansible 6.5.0 distribution.

Us installing collections manually means we're overriding whatever is installed by the user on their system. We'd then need to maintain these collections (it's not just ansible.posix, I think) up to date. I don't know if these collections work on all versions of Ansible we support or if some releases work on newer versions only.

On the plus side, we'll know that all dependencies are installed and pinned to versions we know to work.

@etkecc
Copy link
Contributor

etkecc commented Nov 7, 2022

ansible-core and ansible are completely different things nowadays. The core package contains ansible "engine" and builtin modules/plugins only, the ansible package contains collections and whatnot.

Playbook's requirement is ansible, not just ansible-core.
@spantaleev due to confusing naming of ansible packages, could you update the prerequisites to explicitly state that playbook requires both (ansible and ansible-core), please? That part, specifically:

The Ansible program being installed on your own computer

of the https://github.com/spantaleev/matrix-docker-ansible-deploy/blob/master/docs/prerequisites.md#prerequisites section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants