Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartdenovo: fix compile error for debian #17435

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

darmac
Copy link
Contributor

@darmac darmac commented Jul 9, 2020

smartdenovo compile fail on Debian.
The issue is the same as ruanjue/smartdenovo#35
And someone give a fix suggestion on ruanjue/smartdenovo#22

@adamjstewart
Copy link
Member

Flake8:

var/spack/repos/builtin/packages/smartdenovo/package.py:21: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/smartdenovo/package.py:24: [E128] continuation line under-indented for visual indent

@darmac
Copy link
Contributor Author

darmac commented Jul 10, 2020

Flake8:

var/spack/repos/builtin/packages/smartdenovo/package.py:21: [E128] continuation line under-indented for visual indent
var/spack/repos/builtin/packages/smartdenovo/package.py:24: [E128] continuation line under-indented for visual indent

How to resolve this issue? I can't reproduce that log by typing spack flake8

@adamjstewart
Copy link
Member

Just put them all on the same line or indent to the same level as the opening parentheses. You may need to install a newer version of flake8 to reproduce locally.

@darmac
Copy link
Contributor Author

darmac commented Jul 14, 2020

Just put them all on the same line or indent to the same level as the opening parentheses. You may need to install a newer version of flake8 to reproduce locally.

Fixed this issue in 568baf2

@alalazo alalazo merged commit fa61440 into spack:develop Jul 14, 2020
@darmac darmac deleted the smartdenovo branch September 1, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants