Add a basic buildcache pruning application #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @kwryankrattiger |
scottwittenburg
force-pushed
the
alternate-pruning-method
branch
from
c2d2f04
to
5e419e9
Compare
By ensuring at least one space before "develop", we avoid associating
testing urls with some of the hashes in the mirror, which can cause
failure to prune those hashes from the actual mirrors. Example of
bogus url in the bucket that triggered this issue:
s3://spack-binaries/rheltest/develop/tutorial/build_cache/...
There was one issue in this script that would only check timestamps on the pipeline but not the archive, which lead to race conditions when pruning using a time stamp provided by the other pruning method. Now the timestamp cutoff for "updated-before" is respected by both the get_pipelines and generate_pruning_lists methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #415 but developed independently. Currently used to cross-check pruning lists generated by that PR.