Record EC2 instance type for builder pods #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our OpenSearch records to include the type of instance that a job ran on.
mvandenburgh
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
It appears that no job has managed to grab pod info since
#427 was merged yesterday. It seems that the runner pods are disappearing before the taxonomy job runs... but assuming I can get that working, this PR makes sense to me 👍
I was worried about that, but thanks for digging into it & letting us know. In the meantime I'll ponder alternate strategies to grab this info while it's available. |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our OpenSearch records to include the type of instance that a job ran on.