Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: numpy 2 and astropy 6.1 compat, bump minversions #387

Merged
merged 3 commits into from Apr 11, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 5, 2024

Description

This pull request is to address impending numpy 2.0 release.

Fixes #386

and bump minversion of Python and dependencies.
@pllim pllim added this to the 1.4.0 milestone Apr 5, 2024
@pllim pllim added the Build wheels Test wheels on PR label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (0edcfb2) to head (570f216).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   96.83%   97.21%   +0.37%     
==========================================
  Files          17       17              
  Lines        2056     2047       -9     
==========================================
- Hits         1991     1990       -1     
+ Misses         65       57       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2024

@ariedel , does ETC team want to take this for a spin before I merge? This builds synphot C-ext against numpy 2.x ABI but should still be compatible with numpy 1.x to some degree.

@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2024

Please let me know if you also need an accompanying stsynphot PR though I don't see why because stsynphot does not have C-extension.

Copy link

@ariedel ariedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ETC still uses numpy 1.x, but I've taken this branch for a spin and the ETC functions perfectly well with the changes.

@pllim pllim merged commit fc83a69 into spacetelescope:master Apr 11, 2024
26 of 27 checks passed
@pllim pllim deleted the np-2-astropy-6.1 branch April 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: Drop Python 3.9
2 participants