Obviate need to start plugins in user's ginga_config.py #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change gingawrapper to set autostart for plugins previously started in custom ginga_config.py - make them not appear in the optray - disable the PluginConfig from ginga v5
pllim
reviewed
Feb 15, 2024
| @@ -51,9 +51,11 @@ def run_stginga(sys_argv): | |||
| # new_argv[new_argv.index('-t') + 1] = 'qt' | |||
|
|
|||
| # Auto start core global plugins | |||
| for gplgname in ('ChangeHistory', ): | |||
| for gplgname in ('ChangeHistory', 'Zoom', 'Header'): | |||
There was a problem hiding this comment.
I am not sure about this because I have wss_tools set up to use ginga_config.py downstream but I am not its maintainer anymore. So the least disruptive, the better. Is this really necessary?
Over there, we use different flavors of ginga_config.py dependending on the "operation mode":
https://github.com/spacetelescope/wss_tools/tree/master/wss_tools/quip/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the stginga wrapper to auto start the
ZoomandHeaderplugins, which previously were auto started by writing a customginga_config.py. Furthermore, this hides them when in the Operations tray, so that they appear more like other "required" plugins. Finally, this disables the upcomingPluginConfigplugin in Ginga v5, so thatstgingausers cannot customize their plugins, except in the old way of modifyinggeneral.cfgor with aginga_config.py.