Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dev wheels properly #222

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 19, 2023

You can simplify devdeps calls and you can also install astropy dev from wheel.

@pllim pllim requested a review from a team as a code owner October 19, 2023 17:08
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d44cd8) 84.31% compared to head (99afc5f) 84.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          35       35           
  Lines        6452     6452           
=======================================
  Hits         5440     5440           
  Misses       1012     1012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, for what it's worth

@pllim
Copy link
Contributor Author

pllim commented Dec 5, 2023

@pllim
Copy link
Contributor Author

pllim commented Dec 5, 2023

But do you actually use devdeps? I don't see it in the jobs here.

@zacharyburnett
Copy link
Collaborator

But do you actually use devdeps? I don't see it in the jobs here.

#213 adds devdeps as an optional workflow when adding the run devdeps tests label, but it isn't merged yet

@pllim
Copy link
Contributor Author

pllim commented Dec 5, 2023

OK, then maybe you can merge this first and see if this setup really works on your other PR. 🤞

Or feel free to cherry pick the commits over and close this without merge.

@zacharyburnett zacharyburnett merged commit 0971248 into spacetelescope:main Dec 5, 2023
23 checks passed
@pllim pllim deleted the patch-1 branch December 5, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants