Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3618: Add intermediate LRS slit wcs reference frame #8475

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented May 9, 2024

Resolves JP-3618 by adding an intermediate alpha-beta slit reference frame in the LRS distortion transform between detector pixels and v2v3.

DO NOT MERGE- requires further testing.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (17e0cd9) to head (746fad2).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8475      +/-   ##
==========================================
+ Coverage   56.38%   56.54%   +0.15%     
==========================================
  Files         387      387              
  Lines       38716    38869     +153     
==========================================
+ Hits        21830    21977     +147     
- Misses      16886    16892       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse marked this pull request as draft May 9, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant