New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3102: NIRSpec combined MOS/FS processing #8467
Draft
melanieclarke
wants to merge
22
commits into
spacetelescope:master
Choose a base branch
from
melanieclarke:nirspec_mos_fs
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
JP-3102: NIRSpec combined MOS/FS processing #8467
melanieclarke
wants to merge
22
commits into
spacetelescope:master
from
melanieclarke:nirspec_mos_fs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8467 +/- ##
==========================================
+ Coverage 57.93% 58.91% +0.97%
==========================================
Files 387 387
Lines 38839 38953 +114
==========================================
+ Hits 22502 22948 +446
+ Misses 16337 16005 -332 ☔ View full report in Codecov by Sentry. |
melanieclarke
force-pushed
the
nirspec_mos_fs
branch
from
May 8, 2024 16:57
6d6fc0a
to
0e75426
Compare
melanieclarke
force-pushed
the
nirspec_mos_fs
branch
from
May 16, 2024 17:22
31897e1
to
8dce641
Compare
…ithout MSA file source definition
melanieclarke
force-pushed
the
nirspec_mos_fs
branch
from
May 23, 2024 21:18
ddaf8d7
to
d06baa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3102
Closes #7769
WIP: Process fixed slits defined in MSA metafiles, alongside standard MOS slits.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR