Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3102: NIRSpec combined MOS/FS processing #8467

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

melanieclarke
Copy link
Contributor

@melanieclarke melanieclarke commented May 7, 2024

Resolves JP-3102

Closes #7769

WIP: Process fixed slits defined in MSA metafiles, alongside standard MOS slits.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 50.80214% with 92 lines in your changes are missing coverage. Please review.

Project coverage is 58.91%. Comparing base (781e0e0) to head (d06baa7).
Report is 12 commits behind head on master.

Files Patch % Lines
jwst/pipeline/calwebb_spec2.py 5.26% 72 Missing ⚠️
jwst/master_background/nirspec_utils.py 45.45% 12 Missing ⚠️
jwst/wavecorr/wavecorr.py 79.31% 6 Missing ⚠️
jwst/master_background/expand_to_2d.py 0.00% 1 Missing ⚠️
jwst/pipeline/calwebb_spec3.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8467      +/-   ##
==========================================
+ Coverage   57.93%   58.91%   +0.97%     
==========================================
  Files         387      387              
  Lines       38839    38953     +114     
==========================================
+ Hits        22502    22948     +446     
+ Misses      16337    16005     -332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment