New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3513: Remove warning about inaccurate errors #8258
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8258 +/- ##
===========================================
+ Coverage 56.38% 75.77% +19.39%
===========================================
Files 387 476 +89
Lines 38716 39373 +657
===========================================
+ Hits 21830 29836 +8006
+ Misses 16886 9537 -7349
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing would make this PR perfect: set default weight to exptime, especially given that #7563 still hasn't been approved.
6430d06
to
d6c16b8
Compare
d6c16b8
to
5c505f4
Compare
This should not be merged until there's consensus as to whether the warning message is accurate (i.e. I don't think it's benign, as has been suggested). |
@hbushouse @drlaw1558 - can this one be merged, now that error propagation for exptime and ivm weights are handled self-consistently (#8437)? |
@melanieclarke Seems reasonable to me as the entire point of all of that work was to fix the error propagation! @hbushouse 's call though. |
Resolves JP-3513
Closes #
This PR addresses removal of unnecessary warning when weight_type is set to 'exptime':
"Use of EXPTIME weighting will result in incorrect propagated errors in the resampled product". Errors are propagated identically for the 'exptime' and 'ivm' weight options.
The message is benign, but it has been asked about in helpdesk questions, and might unnecessarily deter users from using 'exptime' weights in place of 'ivm'.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR