Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3513: Remove warning about inaccurate errors #8258

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

penaguerrero
Copy link
Contributor

Resolves JP-3513

Closes #

This PR addresses removal of unnecessary warning when weight_type is set to 'exptime':
"Use of EXPTIME weighting will result in incorrect propagated errors in the resampled product". Errors are propagated identically for the 'exptime' and 'ivm' weight options.

The message is benign, but it has been asked about in helpdesk questions, and might unnecessarily deter users from using 'exptime' weights in place of 'ivm'.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner February 2, 2024 15:43
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (6580914) to head (7d15aaf).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8258       +/-   ##
===========================================
+ Coverage   56.38%   75.77%   +19.39%     
===========================================
  Files         387      476       +89     
  Lines       38716    39373      +657     
===========================================
+ Hits        21830    29836     +8006     
+ Misses      16886     9537     -7349     
Flag Coverage Δ *Carryforward flag
nightly 77.68% <ø> (?) Carriedforward from c5678cb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing would make this PR perfect: set default weight to exptime, especially given that #7563 still hasn't been approved.

@hbushouse
Copy link
Collaborator

This should not be merged until there's consensus as to whether the warning message is accurate (i.e. I don't think it's benign, as has been suggested).

@melanieclarke
Copy link
Contributor

@hbushouse @drlaw1558 - can this one be merged, now that error propagation for exptime and ivm weights are handled self-consistently (#8437)?

@drlaw1558
Copy link
Collaborator

@melanieclarke Seems reasonable to me as the entire point of all of that work was to fix the error propagation! @hbushouse 's call though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants