JP-3250: Exclude entire var if any NaN present #7711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3250
Closes #7647
This PR addresses an issue found when a variance array contains NaN values - the sum with the other variance arrays leads to NaN values in the error arrays. The current behavior will propagate any NaNs in a variance array to the final error array.
The approach in this PR is to fully exclude a variance array if at least one NaN is present - this is to prevent the error array from having a variable number of contributions. Alternatively, one could let the error array exclude the NaN values from summation for individual variance entries, leading to the error having 0-3 variance contributions depending on the number of NaNs present.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR