Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure log payload passed to MultilineLogger is a string #7616

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zacharyburnett
Copy link
Collaborator

Closes #6407

This PR addresses the issue in #6407 where initializing matplotlib logging with usetex=True would cause the log message passed to the multiline logging handler to be bytes instead of the expected str

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett changed the title ensure log payload is string ensure log payload passed to MultiLineLogger is a string Jun 23, 2023
@zacharyburnett zacharyburnett changed the title ensure log payload passed to MultiLineLogger is a string ensure log payload passed to MultilineLogger is a string Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.38%. Comparing base (6580914) to head (719f1bc).
Report is 2 commits behind head on master.

Files Patch % Lines
jwst/associations/lib/log_config.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7616      +/-   ##
==========================================
- Coverage   56.38%   56.38%   -0.01%     
==========================================
  Files         387      387              
  Lines       38716    38718       +2     
==========================================
+ Hits        21830    21831       +1     
- Misses      16886    16887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review May 1, 2024 14:01
@zacharyburnett zacharyburnett requested a review from a team as a code owner May 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log raises TypeError when matplotlib usetex=True
1 participant