Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filename parser test over filesystem #1586

Merged
merged 2 commits into from May 13, 2024
Merged

Remove filename parser test over filesystem #1586

merged 2 commits into from May 13, 2024

Conversation

bhilbert4
Copy link
Collaborator

Resolves #1308

Remove test_filename_parser_whole_filesystem(). This isn't a very useful test and would take ages to run now that we have a large filesystem.

@bhilbert4 bhilbert4 self-assigned this May 10, 2024
@bhilbert4 bhilbert4 requested a review from mfixstsci May 10, 2024 21:09
@bhilbert4
Copy link
Collaborator Author

@mfixstsci I came across this old open issue and decided to get in a quick fix. This is ready for review.

mfixstsci
mfixstsci approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the issue that caused this change. If we skip it and it take forever to run locally, then we can remove it.

@mfixstsci mfixstsci merged commit c9033f3 into spacetelescope:develop May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfixstsci mfixstsci mfixstsci approved these changes

Assignees

@bhilbert4 bhilbert4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove test_filename_parser_whole_filesystem() from test_utils.py
2 participants
@bhilbert4 @mfixstsci