Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use build workflow from OpenAstronomy #1403

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 27, 2023

adds a build workflow that also does publishing to PyPI (but only on a release)

image

@mfixstsci
Copy link
Collaborator

Hey @zacharyburnett thanks for the submission, our team is currently discussing how long JWQL will remain on pypi. The tool is open source (visible to the community through github) but is not intended to be an installable package for the public. I think the intent behind publishing to pypi was more of a formality than something of practical use in the past. I will make sure to keep you in the loop here on what we decide to do.

Comment on lines +12 to +15
with:
upload_to_pypi: ${{ (github.event_name == 'release') && (github.event.action == 'released') }}
secrets:
pypi_token: ${{ secrets.PYPI_PASSWORD_STSCI_MAINTAINER }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfixstsci ok! then if you do decide to no longer publish to PyPI, you can also use this workflow just as a build check (if you think that's useful):

Suggested change
with:
upload_to_pypi: ${{ (github.event_name == 'release') && (github.event.action == 'released') }}
secrets:
pypi_token: ${{ secrets.PYPI_PASSWORD_STSCI_MAINTAINER }}
with:
upload_to_pypi: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants