Expand wildcards in file names. #182
Conversation
c_imt.c was modified to allow the use of wildcards in file names by including glob.h and using its glob function. See hstcal issue spacetelescope#181.
|
I added one person per instrument to review this. Others can review too if they want to even if not assigned. |
|
Sorry for not yet having reviewed this: I will take a look soon. My reservation deterring me from doing so is the following: Whilst it is already possible (assuming this functionality works) to give a comma delimited list of input files to 'batch' process, I doubt that this is used, perhaps at all. I think though, that a wildcard ('*') filename expansion would be. My greatest concern with this issue/functionality is the iteration of the code at the root level - is this safe?! I feel that a fair bit of attention would be required to fulfill this feature request, e.g. fix all memory leaks, clean-up/reset all global variables etc. |
|
A comma-separated list is useful when you want to process a few files but not all that might be picked up by using a wildcard. A wildcard would be especially useful when running a calxxx routine on a large set of files for a regression test, something that is done every time there's a new delivery to DMS. If there are memory leaks or other such problems, it would be nice to find them. The cosmic-ray rejection functions are often used with a few dozen input files, sometimes more. |
Exactly, the regression test scenario is the very the reason that I opened #179 |
c_imt.c was modified to allow the use of wildcards in file names by
including glob.h and using its glob function.
See hstcal issue #181.
EDIT: Fix #181