fix: [#4520] Upgrade restify to fix error on Node version 18+ #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
changed the title
sw-joelmut
approved these changes
Aug 24, 2023
|
/promoted 4528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 4520
#minor
Description
This PR upgrades the restify dependency to version 11.1.0 to avoid the error on Node 18+.
It also updates the target in TS bots, as the new version of restify introduced a breaking change.
Additionally, it upgrades botbuilder packages to version 4.20.0 and fixes an eslint issue in the core bot's index.ts.
Specific Changes
restifyversion 11.1.0.botbuilderpackages to version 4.20.0.tsconfig.json's target property to es2017.templates/core/index.ts.Testing
These images show the generated bots working and the tests in core-with-tests passing.
