TSC Graph Context: fix performance #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good news: I've maybe the biggest performance mistake (not caching script snapshots) so loading the compiler is now only slow once (not on every keystroke!). Bad news: loading the compiler is still too slow in large codebases (6s in sg/sg) and symbol collection is still too slow (~200ms) for a small file. |
olafurpg
force-pushed
the
olafurpg/cody-1434-faster-performance
branch
3 times, most recently
from
ec6e573
to
90a0cbd
Compare
Fixes CODY-1434 Previously, the `tsc-mixed` context retriever made the UI freeze because it was doing super inefficient things with context expansion. This PR fixes the problem so that the performance is back to normal.
olafurpg
force-pushed
the
olafurpg/cody-1434-faster-performance
branch
from
90a0cbd
to
97b578a
Compare
|
Tagged stampers for review since this is a low-risk PR to merge. The TSC context is disabled by default |
burmudar
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CODY-1434
Previously, the
tsc-mixedcontext retriever made the UI freeze because it was doing super inefficient things with context expansion. This PR fixes the problem so that the performance is back to normal.Test plan
Green CI.
I tested this change manually in large projects and confirmed that the latency overhead for tsc context-retriever is no longer huge. For example, it's 33ms here on line 1300 in the largest file in svelte/language-tools repo
