Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit message generator #4011

Closed
wants to merge 9 commits into from
Closed

Add commit message generator #4011

wants to merge 9 commits into from

Conversation

umpox
Copy link
Contributor

@umpox umpox commented May 2, 2024

Description

TODO

Test plan

Copy link

github-actions bot commented May 2, 2024

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces usage of unsafe_ functions or abuses PromptString.

Copy link

github-actions bot commented May 2, 2024

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces usage of unsafe_ functions or abuses PromptString.

@RXminuS
Copy link
Contributor

RXminuS commented May 2, 2024

Hahaha @umpox being naughty with the prompt string according to GH bot 😂

I had a quick skim at the Cody ignore stuff and I think the approach for now is to complain to the user if bad context is included; not to filter / mask it. But I don't think it should be very hard to extend with more options there. I don't think we'll have to do the filtering inside the scm specific code as long as we construct our URIs with the gitroot basepath.

In that case I don't see a blocker for releasing outside experimental as any TODOs on the codyignore affects more than just this feature and could just be fixed as separate PRs.

Copy link

github-actions bot commented May 8, 2024

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces the usage of an unsafe_ function or abuses PromptString.

@umpox
Copy link
Contributor Author

umpox commented May 13, 2024

Closed in favour of #4130

@umpox umpox closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants