-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UNSAT core to the OpenSMT backend #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and marked as 'experimental' in OpenSMT.
…NERATE_MODELS was acutally selected.
…port for unsat core in its more general logics.
…at core to theory combinations and arrays.
…acks support for unsat core in its more general logics." This reverts commit 744c261.
kfriedberger
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. however, I have not yet tested it.
Who will compile and publish the new version of OpenSMT infor our Ivy and Maven?
UPDATE after waiting a week:
I will compile and publish OpenSMT to Ivy and Maven repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request adds support for the new method MainSolver.getUnsatCore() to our JavaSMT backend for OpenSMT. The feature is still experimental in OpenSMT and so far only the logics QF_UF, QF_LIA and QF_LRA are supported. More details can be found here.