fix UnitBox memory leak in UCE #1655
Open
+158
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swissiety can you review this? |
swissiety
reviewed
Jun 18, 2021
|
|
||
| // Assert that the set of boxes obtained from all units equals the set | ||
| // obtained by checking Unit#getBoxesPointingToThis() on all units. | ||
| Assert.assertEquals(new HashSet<>(getAllUnitBoxes(body)), new HashSet<>(getAllBoxesPointingToUnits(body))); |
There was a problem hiding this comment.
please assert that the transformer changed sth i.e. removed the trap
swissiety
reviewed
Jun 18, 2021
Comment on lines
+105
to
+108
| UnitBox beginBox = trap.getBeginUnitBox(); | ||
| UnitBox endBox = trap.getEndUnitBox(); | ||
| UnitBox handlerBox = trap.getHandlerUnitBox(); | ||
| if ((beginBox.getUnit() == endBox.getUnit()) || !reachable.contains(handlerBox.getUnit())) { |
There was a problem hiding this comment.
please restructure the UnitBox assignments inside the if block so the assignments are just executed when needed
There was a problem hiding this comment.
I don't think any improvement can be made. The first two (beginBox and endBox) will always be used since they are in the first condition. The final variable (handlerBox) will always be used as well. If the first condition is true, it will be used inside the if statement body and if the first condition is false, it will be used in the second condition (and possibly again inside the body).
This ensures the trap was actually removed as expected. Also, rename the test method to something more meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.