Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FieldRef classes #1519

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Update FieldRef classes #1519

wants to merge 10 commits into from
+311 −83

Conversation

tim-hoffman
Copy link
Member

  • formatting and cleanup
  • caching of the resolved SootField in AbstractSootFieldRef because it can be an expensive operation

@linghuiluo
Copy link
Member

@swissiety can you review this ?

@linghuiluo
Copy link
Member

@swissiety Is this PR ready for merging?

@swissiety
Copy link
Collaborator

@linghuiluo that depends on whether we want a SootField caching mechanism that works globally instead of locally per FieldRef as it is introduced in this PR

@tim-hoffman
Copy link
Member Author

Regardless, local caching does provide an improvement. Changing to global caching could be considered separately in the future.

@tim-hoffman tim-hoffman marked this pull request as draft June 18, 2021 14:49
@tim-hoffman tim-hoffman marked this pull request as ready for review June 18, 2021 16:56
@tim-hoffman tim-hoffman mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissiety swissiety swissiety left review comments

@linghuiluo linghuiluo linghuiluo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tim-hoffman @linghuiluo @swissiety