modem-config: Fix path for for Finnish providers Elisa and DNA #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later firmware partitions use a different file layout. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
|
Config files for other provides are also still wrong. |
In general the rule is the following: - euro -> EU - country names like Fin are written out like Finland - Provider names are capitalized, all uppercase if ISO country code or sometimes changed from ISO country code to full name - Switch from VLVW to Commercial
|
This the first batch of changes. I'm not entirely sure how the renames are handled for some cases. |
|
The first commit can be taken as is thou still. |
lkraav
reviewed
Jul 15, 2022
| mcfg_sw/generic/EU/Elisa/VLVW/Estonia/mcfg_sw.mbn |
There was a problem hiding this comment.
Why would you be changing fin -> Estonia here?
lkraav
reviewed
Jul 15, 2022
| mcfg_sw/generic/EU/DNA/VLVW/Finlandland/mcfg_sw.mbn |
|
@Thaodan can you please answer the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later firmware partitions use a different file layout.