-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay: core: config: Enable night display on all platforms. #573
base: master
Are you sure you want to change the base?
Conversation
This boolean is required to show and enable the night display settings. Not all platforms strictly adhere to the power/performance requirements, for example Loire requires a fallback to GPU transformations because the reported HWC2.0 functionality doesn't work, and a similar issue arises on Nile SDE that has yet to be solved. The power hit doesn't seem nearly as bad, and enabling it allows more testing and eventually pinning the issue in libsdm-color that prevents the hardware transformation from happening. Change-Id: Icfaed3ee74bf25cde2b6a4fcf5c780b14bedb896 Signed-off-by: MarijnS95 <marijns95@gmail.com>
3cc88ac
to
784b86e
Compare
699ce56
to
5d1178b
Compare
120f053
to
dea89a4
Compare
436c964
to
68bc1eb
Compare
b818544
to
d165b35
Compare
Hi @MarijnS95, would you mind rebasing this? Thanks! |
@pablomh I can, but not sure if I should: Unfortunately the discussion didn't end up here but the gist of it is that we don't want to merge this because it's not a pure HW implementation but applied "in software" through a GL shader on legacy devices. Those have their own Q branch now and afaik everything on |
So this would be more appropriate on q-mr1 branch only, neat |
69cec5f
to
494cb0f
Compare
b5f507d
to
2ae1682
Compare
1261548
to
86e3f82
Compare
c111d8c
to
8a07b68
Compare
101dc8e
to
0ee9a93
Compare
6150624
to
0efcdaa
Compare
96e8edc
to
87bf40a
Compare
Fixes sonyxperiadev/bug_tracker#319.
This property was apparently overlooked, since it is enabled on some custom roms built on top of Sony Open Devices, and works fine on most/all devices.
Work has gone into a fallback to apply the transformation in the GPU, due to an error in
libsdm-color
ssetColorTransform
on Loire devices (and others?). Nile shows a very similar issue since switching to SDE. @jerpelea Would it be possible to check these cases again in the closed-source blobs? For Loire, it'd be nice to use the (advertised) HW transformation (or get rid of that advertisement), and for Nile something else must be wrong; afaik it worked fine before SDE, so there's no point in using a GPU fallback now.sonyxperiadev/bug_tracker#80 for reference.
Commit description: