Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: core: config: Enable night display on all platforms. #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarijnS95
Copy link
Contributor

Fixes sonyxperiadev/bug_tracker#319.

This property was apparently overlooked, since it is enabled on some custom roms built on top of Sony Open Devices, and works fine on most/all devices.
Work has gone into a fallback to apply the transformation in the GPU, due to an error in libsdm-colors setColorTransform on Loire devices (and others?). Nile shows a very similar issue since switching to SDE. @jerpelea Would it be possible to check these cases again in the closed-source blobs? For Loire, it'd be nice to use the (advertised) HW transformation (or get rid of that advertisement), and for Nile something else must be wrong; afaik it worked fine before SDE, so there's no point in using a GPU fallback now.
sonyxperiadev/bug_tracker#80 for reference.

Commit description:

This boolean is required to show and enable the night display settings.
Not all platforms strictly adhere to the power/performance requirements,
for example Loire requires a fallback to GPU transformations because the
reported HWC2.0 functionality doesn't work, and a similar issue arises
on Nile SDE that has yet to be solved. The power hit doesn't seem nearly
as bad, and enabling it allows more testing and eventually pinning the
issue in libsdm-color that prevents the hardware transformation from
happening.

This boolean is required to show and enable the night display settings.
Not all platforms strictly adhere to the power/performance requirements,
for example Loire requires a fallback to GPU transformations because the
reported HWC2.0 functionality doesn't work, and a similar issue arises
on Nile SDE that has yet to be solved. The power hit doesn't seem nearly
as bad, and enabling it allows more testing and eventually pinning the
issue in libsdm-color that prevents the hardware transformation from
happening.

Change-Id: Icfaed3ee74bf25cde2b6a4fcf5c780b14bedb896
Signed-off-by: MarijnS95 <marijns95@gmail.com>
@pablomh
Copy link
Contributor

pablomh commented Sep 4, 2020

Hi @MarijnS95, would you mind rebasing this? Thanks!

@MarijnS95
Copy link
Contributor Author

@pablomh I can, but not sure if I should:

Unfortunately the discussion didn't end up here but the gist of it is that we don't want to merge this because it's not a pure HW implementation but applied "in software" through a GL shader on legacy devices. Those have their own Q branch now and afaik everything on q-mr1 properly supports HWC transforms. We have kernel support too that takes care of merging this transformation together with color calibration in the kernel.

@Paulbouchara
Copy link
Contributor

So this would be more appropriate on q-mr1 branch only, neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redacted
3 participants