Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redacted #319

Closed
ghost opened this issue Jan 31, 2019 · 4 comments · May be fixed by sonyxperiadev/device-sony-common#573
Closed

redacted #319

ghost opened this issue Jan 31, 2019 · 4 comments · May be fixed by sonyxperiadev/device-sony-common#573

Comments

@ghost
Copy link

ghost commented Jan 31, 2019

redacted

@ghost ghost changed the title Do these Xperias have Hardware Composer HAL 2.0 (HWC 2) implementation that can apply the matrix passed to setColorTransform to perform tinting? [Night Light support] Do these Xperias have Hardware Composer HAL 2.0 (HWC 2) implementation that can apply the matrix passed to setColorTransform to perform tinting? Jan 31, 2019
@MarijnS95
Copy link
Contributor

On Suzu (probly the entire Loire platform):
The underlying display driver/library reports to HWC2 that it supports it, but errors out when using it.
We've added a property to use the GPU fallback path in #80.
I don't know where the problem lies; it could be lacking hardware support, or the blobs/kernel are messed up.

A similar problem occurs on Discovery (Nile platform) with SDE; something returns an error on the closed-source blob side. Even with extremely verbose debug logging, no obvious errors are seen in the kernel.
(That said, I can't remember if nightlight was working there before. But I can definitely tell the hardware responsible for this transform functions just fine, as tested for sonyxperiadev/kernel#1892).

It works just fine on Tama. I don't know about Yoshino or Tone.

@jerpelea
Copy link
Collaborator

jerpelea commented Feb 1, 2019

tone, yoshino and tama are working fine

@jerpelea jerpelea closed this as completed Feb 1, 2019
@MarijnS95
Copy link
Contributor

@gerg5c42g542g2c54g52c So if I understand correctly, all you wanted to ask is whether Night Light is supported on Xperia devices, because the option is not available in the menu?
I've been using Omnirom, and just now see that they have config_nightDisplayAvailable enabled in a global overlay - it is not configured in any of the device-sony- repos.

If so, I'll PR a change to enable it on all platforms. config_setColorTransformAccelerated doesn't seem to be used anywhere else yet, so we can just leave that out until it is used and we are sure which platforms properly support HW accelerated color transforms.

@MarijnS95
Copy link
Contributor

@gerg5c42g542g2c54g52c See the referenced PR.

@ghost ghost changed the title [Night Light support] Do these Xperias have Hardware Composer HAL 2.0 (HWC 2) implementation that can apply the matrix passed to setColorTransform to perform tinting? redacted Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants