Server: Include the file path in error messages when running external files #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should hopefully fix sonic-pi-net#2336
|
😂 as I recall, pretty much the same solution I came up with on my machine also - just never got round to cleaning it up and creating a PR 🙂 I'll double check this, but pretty sure it will be good to go. Thanks! |
SunderB
force-pushed
the
patch/show-filepaths-in-errors
branch
from
572acdf
to
bb447f3
Compare
SunderB
changed the title
SunderB
changed the title
|
Lovely work, thanks! |
|
Sorry, I had to revert this as it was buggy. Please do thoroughly test your code before submitting a pull request. Perhaps next time squash all your commits into a single change so it's easier to triage. Happy to consider a fixed version of this PR. |
|
@samaaron I understand :), I think I tested it a while ago and it seemed to work, but I admit I wasn't that thorough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully fix #2336 🙂 Yet to be tested